Moved the value field of Value in Constant and renamed Value into Expression - #15
Open
d-leroy wants to merge 2 commits into
Open
Moved the value field of Value in Constant and renamed Value into Expression#15d-leroy wants to merge 2 commits into
d-leroy wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Following a discussion with Benoit Combemale and Didier Vojtisek, I edited the arduino language metamodel in order to remove all dynamic information.
I moved the "value" field, initially a member of the Value class, toward the Constant class because it is the only class for which this data is not dynamic (this field is also used by the Variable class but in a dynamic way so is added by aspect weaving).
I also renamed the Value class into Expression since it can also be a MathOperation.